Improve reordering local comics. Close #374

lib/foundation/appdata.dart

@@ -205,7 +205,9 @@ class Settings with ChangeNotifier {
 
   operator []=(String key, dynamic value) {
     _data[key] = value;
-    notifyListeners();
+    if (key != "dataVersion") {
+      notifyListeners();
+    }
   }
 
   @override

lib/foundation/favorites.dart

@@ -714,11 +714,26 @@ class LocalFavoritesManager with ChangeNotifier {
     if (!existsFolder(folder)) {
       throw Exception("Failed to reorder: folder not found");
     }
-    deleteFolder(folder);
-    createFolder(folder);
-    for (int i = 0; i < newFolder.length; i++) {
-      addComic(folder, newFolder[i], i);
+    _db.execute("BEGIN TRANSACTION");
+    try {
+      for (int i = 0; i < newFolder.length; i++) {
+        _db.execute("""
+          update "$folder"
+          set display_order = ?
+          where id == ? and type == ?;
+        """, [
+          i,
+          newFolder[i].id,
+          newFolder[i].type.value
+        ]);
+      }
     }
+    catch (e) {
+      Log.error("Reorder", e.toString());
+      _db.execute("ROLLBACK");
+      return;
+    }
+    _db.execute("COMMIT");
     notifyListeners();
   }
 

lib/pages/favorites/local_favorites_page.dart

@@ -864,7 +864,10 @@ class _ReorderComicsPageState extends State<_ReorderComicsPage> {
   @override
   void dispose() {
     if (changed) {
-      LocalFavoritesManager().reorder(comics, widget.name);
+      // Delay to ensure navigation is completed
+      Future.delayed(const Duration(milliseconds: 200), () {
+        LocalFavoritesManager().reorder(comics, widget.name);
+      });
     }
     super.dispose();
   }
@@ -899,27 +902,31 @@ class _ReorderComicsPageState extends State<_ReorderComicsPage> {
       appBar: Appbar(
         title: Text("Reorder".tl),
         actions: [
-          IconButton(
-            icon: const Icon(Icons.info_outline),
-            onPressed: () {
-              showInfoDialog(
-                context: context,
-                title: "Reorder".tl,
-                content: "Long press and drag to reorder.".tl,
-              );
-            },
-          ),
-          IconButton(
-            icon: const Icon(Icons.swap_vert),
-            onPressed: () {
-              setState(() {
-                comics = comics.reversed.toList();
-                changed = true;
-                showToast(
-                    message: "Reversed successfully".tl, context: context);
-              });
-            },
+          Tooltip(
+            message: "Information".tl,
+            child: IconButton(
+              icon: const Icon(Icons.info_outline),
+              onPressed: () {
+                showInfoDialog(
+                  context: context,
+                  title: "Reorder".tl,
+                  content: "Long press and drag to reorder.".tl,
+                );
+              },
+            ),
           ),
+          Tooltip(
+            message: "Reverse".tl,
+            child: IconButton(
+              icon: const Icon(Icons.swap_vert),
+              onPressed: () {
+                setState(() {
+                  comics = comics.reversed.toList();
+                  changed = true;
+                });
+              },
+            ),
+          )
         ],
       ),
       body: ReorderableBuilder<FavoriteItem>(